Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add gpt widget again #1477

Merged
merged 2 commits into from
Jul 28, 2023
Merged

fix: add gpt widget again #1477

merged 2 commits into from
Jul 28, 2023

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jul 26, 2023 •
edited
Loading

Widget now only executes the script file once the HTML document has been fully parsed.
Also added a privacy disclaimer.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr
Copy link
Member Author

vinckr commented Jul 26, 2023

Screenshot 2023-07-26 at 12 11 33

lighthouse looks good but not sure if the defer works as expected 🤔

@vinckr vinckr marked this pull request as ready for review July 26, 2023 10:14
@aeneasr
Copy link
Member

aeneasr commented Jul 26, 2023

This is desktop lighthouse though, right? You need to check mobile lighthouse as well!

Looks like over 50% of the code bundle is still unused, and it's also loading immediately and not only once we click on the button:

Bildschirmfoto 2023-07-26 um 12 14 23

@vinckr
Copy link
Member Author

vinckr commented Jul 27, 2023

desktop
Lighthouse score with kapa widget
Screenshot 2023-07-28 at 00 27 42
Lighthouse score without kapa widget
Screenshot 2023-07-28 at 00 34 06

mobile
Lighthouse score with kapa widget
Screenshot 2023-07-28 at 00 27 10
Lighthouse score without kapa widget
Screenshot 2023-07-28 at 00 33 43

aeneasr
aeneasr approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still dragging down all the scores but I guess it's more useful to us if it's there?

@vinckr
Copy link
Member Author

vinckr commented Jul 28, 2023

It's still dragging down all the scores but I guess it's more useful to us if it's there?

Agreed!

Thanks 🙏

They want to improve it but its not on the immediate roadmap, so at least 2+ months out.
I will keep on it though.

@vinckr vinckr merged commit 7b595eb into master Jul 28, 2023
8 checks passed
@vinckr vinckr deleted the readd-kapa branch July 28, 2023 10:12
@kmherrmann
Copy link
Contributor

one more thought: could we just disable it on mobile, where it hurts the scores more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

@kmherrmann kmherrmann Awaiting requested review from kmherrmann

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinckr @aeneasr @kmherrmann